-
-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(organizations): member role selector TASK-986 #5315
Conversation
β¦e-endpoints-to-handle-org-members
β¦ query for user mfa details
β¦hook more customizable and then use it in `MembersRoute`
β¦hook more customizable and then use it in `MembersRoute`
β¦x/kpi into leszek/task-980-members-table
β¦eszek/task-980-members-table
β¦omprehensive tests
β¦omprehensive tests
β¦eszek/task-980-members-table
β¦x/kpi into leszek/task-980-members-table
β¦eszek/task-980-members-table
β¦x/kpi into leszek/task-980-members-table
β¦ers-table-actions-dropdown
β¦sk-986-member-role-selector
β¦ers-table-actions-dropdown
β¦sk-986-member-role-selector
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left one minor comment. This is good to merge after reading and/or addressing it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm.
One note: Given the way we are squashing merges now, it would probably be best to merge this into main
(after merging the work for task 987) rather than into the 987 branch.
π£ Summary
In Members Table (from Account β Team/Organization β Members) add UI for changing member's role.
π Description
Only owner and admins can modify the role.
π Preview steps
mmosEnabled
#/account/organization/members
(as "joe")As continuation for above steps:
#/account/organization/members
π Notes
Build atop #5309